-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default value of NRLoggingEnabled
Parameter to True
#122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maya-jha
reviewed
Sep 1, 2024
Added the details of testing and Jira Id to the desription. |
Can you update README.md and remove
|
858cd0f
to
3aa6a0b
Compare
maya-jha
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Signed-off-by: Akhil <asyamala@newrelic.com>
Signed-off-by: Akhil <asyamala@newrelic.com>
Signed-off-by: Akhil <asyamala@newrelic.com>
Signed-off-by: Akhil <asyamala@newrelic.com>
Signed-off-by: Akhil <asyamala@newrelic.com>
3aa6a0b
to
136559b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NRLoggingEnabled
to TrueManual Testing:
- Manually tested the Lambda function with the
loggingEnabled
variable set to true.- Verified that logs are being forwarded to NewRelic.
- Confirmed the function's behavior and performance with logging enabled and logging disabled.
- Ensured no unintended behavior or issues were introduced.
Automated Testing:
- Executed all the test cases present in the
tests
folder of the repository.- Ensured that all tests passed successfully without any errors or failures.