Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value of NRLoggingEnabled Parameter to True #122

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

AkhilReddyS-NR
Copy link
Contributor

@AkhilReddyS-NR AkhilReddyS-NR commented Aug 28, 2024

  • Changed the default value of the Parameter NRLoggingEnabled to True
  • This change eases the deployment process for customers by removing the need to manually configure logging .
  • Details of testing done
    Manual Testing:
    - Manually tested the Lambda function with the loggingEnabled variable set to true.
    - Verified that logs are being forwarded to NewRelic.
    - Confirmed the function's behavior and performance with logging enabled and logging disabled.
    - Ensured no unintended behavior or issues were introduced.
    Automated Testing:
    - Executed all the test cases present in the tests folder of the repository.
    - Ensured that all tests passed successfully without any errors or failures.
  • Jira story - NR-303954

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2024

CLA assistant check
All committers have signed the CLA.

@maya-jha
Copy link

maya-jha commented Sep 1, 2024

  1. Can you add details of testing done.
  2. Also add the Jira/github issue id.

serverless.yml Outdated Show resolved Hide resolved
@AkhilReddyS-NR
Copy link
Contributor Author

  1. Can you add details of testing done.
  2. Also add the Jira/github issue id.

Added the details of testing and Jira Id to the desription.

@maya-jha
Copy link

maya-jha commented Sep 4, 2024

Can you update README.md and remove

* To set `LOGGING_ENABLED`: `sam build ... --parameter-overrides 'ParameterKey=NRLoggingEnabled,ParameterValue=True'`
* To set `LOGGING_ENABLED`: `export LOGGING_ENABLED=True` (prior to deploy)```

Copy link

@maya-jha maya-jha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Signed-off-by: Akhil <asyamala@newrelic.com>
Signed-off-by: Akhil <asyamala@newrelic.com>
Signed-off-by: Akhil <asyamala@newrelic.com>
Signed-off-by: Akhil <asyamala@newrelic.com>
Signed-off-by: Akhil <asyamala@newrelic.com>
@AkhilReddyS-NR AkhilReddyS-NR merged commit 020955f into newrelic:master Sep 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants