Search for host networking mode containers by name during stop_containers #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ners. If a service uses host networking mode and you define a public port for the purpose of healthchecking, the stop container call fails because no such port is actually mapped. This workaround allows you to define a "dummy" port that won't be mapped (since host mode doesn't do that) but still satisfies the wait_for_health_check_ok semantics by passing the port through. It is a little weird that centurion "thinks" the port mappings exist without docker actually creating them. Resolves #164.
|
Seems legit. I agree that it's a weird implementation, but it does seem like the most natural way to solve the problem currently without a noticeable (probably low value) refactor. |
|
🐑 🐐 🐐 🐑 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a service uses host networking mode and you define a public port
for the purpose of healthchecking, the stop container call fails because
no such port is actually mapped.
This workaround allows you to define a "dummy" port that won't be mapped
(since host mode doesn't do that) but still satisfies the
wait_for_health_check_ok semantics by passing the port through.
It is a little weird that centurion "thinks" the port mappings exist
without docker actually creating them.
Resolves #164.