Add ability to pass ssh socket heartbeat interval #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failure for this PR is addressed in #194 |
When running multiple concurrent deployments over SSH with ruby threads, a race condition can occur where a docker operation reads all data from the forwarded socket before net/ssh can check for readability on the socket with IO.select. Setting an ssh.loop `wait` ensures that the Docker operation block passed to ssh.loop is evaluated at least once per `wait`. Co-authored-by: Christina Guida <cguida@newrelic.com> Co-authored-by: Rob Day-Reynolds <rdayreynolds@newrelic.com> Co-authored-by: Stephen Weber <sweber@newrelic.com>
If this is the case, why default to nil for the What heartbeat value would set after this is merged for your deploy scripts? Can we give guidance as to when to set this parameter and to what value? |
|
@intjonathan Great point. The condition we're seeing may be specific to the way Centurion is being used within |
|
Much better :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running multiple concurrent deployments over SSH with ruby threads, a race
condition can occur where a docker operation reads all data from the
forwarded socket before net/ssh can check for readability on the socket
with IO.select. Setting an ssh.loop
waitensures that the Dockeroperation block passed to ssh.loop is evaluated at least once per
wait.