Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added nrql lessons to page frontmatter resources #636

Merged
merged 2 commits into from
Aug 20, 2020
Merged

added nrql lessons to page frontmatter resources #636

merged 2 commits into from
Aug 20, 2020

Conversation

jpvajda
Copy link
Contributor

@jpvajda jpvajda commented Aug 19, 2020

Description

  • added nrql lessons to resources
  • fixed a missing ' ' on the resource titles on the get-started-nerdgraph-api-explorer page
  • updated style guide to specify you need single quotes around resource titles.

@jpvajda jpvajda self-assigned this Aug 19, 2020
@jpvajda jpvajda added the documentation Improvements or additions to documentation label Aug 19, 2020
@jpvajda jpvajda requested a review from mmfred August 19, 2020 01:09
Copy link
Contributor

@mmfred mmfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, but otherwise, looks good.

@jpvajda
Copy link
Contributor Author

jpvajda commented Aug 20, 2020

Resolved code review comments, merging.

@jpvajda jpvajda merged commit 3893f14 into main Aug 20, 2020
@jpvajda jpvajda deleted the nrql-update branch August 20, 2020 01:43
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.13.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants