Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

need new release of github.com/newrelic/go-agent/v3/integrations/nrawssdk-v1 #499

Closed
rittneje opened this issue May 20, 2022 · 4 comments · Fixed by #503 or newrelic/docs-website#7786
Closed

need new release of github.com/newrelic/go-agent/v3/integrations/nrawssdk-v1 #499

rittneje opened this issue May 20, 2022 · 4 comments · Fixed by #503 or newrelic/docs-website#7786
Labels
bug
Projects
Go Engineering Board

Comments

@rittneje
Copy link
Contributor

github.com/newrelic/go-agent/v3/integrations/nrawssdk-v1@v1.0.1 is incompatible with github.com/newrelic/go-agent/v3@v3.16.0. (This is due to the breaking change I mentioned in #433.) Please release a new version of this integration.

# github.com/newrelic/go-agent/v3/integrations/nrawssdk-v1
../../pkg/mod/github.com/newrelic/go-agent/v3/integrations/nrawssdk-v1@v1.0.1/nrawssdk.go:36:23: cannot use hdr (type http.Header) as type *http.Response in argument to awssupport.EndSegment
@rittneje rittneje added the bug label May 20, 2022
@nr-swilloughby
Copy link
Contributor

We can set up a small release with this change ASAP.

@rittneje
Copy link
Contributor Author

@nr-swilloughby Just wanted to follow up on this.

@nr-swilloughby
Copy link
Contributor

We're putting together a small release this week with this and a couple of other necessary version updates.

@iamemilio iamemilio added this to Awaiting User Input in Go Engineering Board via automation May 25, 2022
@iamemilio iamemilio moved this from Awaiting User Input to To Do in Go Engineering Board May 25, 2022
@nr-swilloughby nr-swilloughby moved this from To Do to In progress in Go Engineering Board May 26, 2022
@nr-swilloughby nr-swilloughby mentioned this issue May 26, 2022
Merged
Go Engineering Board automation moved this from In progress to Done May 26, 2022
@nr-swilloughby nr-swilloughby mentioned this issue May 26, 2022
Merged
@nr-swilloughby
Copy link
Contributor

Bumped the version number to v1.1.0 (was 1.0.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Go Engineering Board
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release v3.16.1 newrelic/go-agent
release 3.16.1 nr-swilloughby/docs-website
2 participants
@rittneje @nr-swilloughby