do not include distributed trace headers in AWS SDK requests #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @nr-swilloughby |
|
@rittneje thank you for reporting this issue and for suggesting a pull request to address it. We'll review the issue and work to resolve it ASAP. |
|
@rittneje Thanks for working on this solution that simply side-steps the whole issue. We still need to do some testing on this, and would welcome others' feedback on this solution! |
|
Tested with sample code, merging with develop. |
RichVanderwal
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427 and #432. Sending the distributed trace headers to AWS is rather pointless, and can cause the request signature to be corrupted on retries. Also, previously the AWS request id and response status code were not being properly captured.
Note: Due to breaking changes in the v3/internal package, the new release of nrawssdk-v1 will depend on the new release of v3. Not sure how this is normally dealt with.