Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Serverless to use a named pipe for telemetry when present #201

Merged
merged 24 commits into from
Aug 10, 2020
Merged

Modify Serverless to use a named pipe for telemetry when present #201

merged 24 commits into from
Aug 10, 2020

Conversation

MattWhelan
Copy link
Contributor

Serverless telemetry is normally sent to stdout. This is an alternate
path designed for use with an externally managed named pipe at a
fixed location.

Links

Details

@purple4reina purple4reina changed the base branch from master to develop August 7, 2020 18:25
Copy link
Contributor

@purple4reina purple4reina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, but all in all this looks good.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
v3/integrations/nrlambda/handler.go Outdated Show resolved Hide resolved
v3/integrations/nrlambda/handler.go Outdated Show resolved Hide resolved
MattWhelan and others added 2 commits August 10, 2020 13:44
Co-authored-by: Rey Abolofia <purple4reina@gmail.com>
@purple4reina purple4reina merged commit 525b608 into newrelic:develop Aug 10, 2020
joshuabenuck pushed a commit to joshuabenuck/go-agent that referenced this pull request Sep 4, 2020
…relic#201)

* Update protobuf file to latest.

f13a86b4b013d2ae07e78c7c27359d0a158be118

* Log gRPC version used.

* Replace usage of deprecated grpc.WithDialer. (newrelic#942)

* Prevent debug messages unless debug level set. (newrelic#943)

* Include request_headers_map from connect reply in RecordSpan metadata. (newrelic#940)

* Fix code strings to match spec. (newrelic#945)

* Add parent.* intrinsics from transaction to root span. (newrelic#946)

* Update span GUID propagation  (newrelic#944)

* Pull in new cross agent tests (not yet passing)

* Code changes for span GUID creation

* Get tests passing

* t.Helper() was added in Go 1.9, so it can't be used here. :(

* PR feedback

* Update commit of cross-agent tests now that PR is merged

* Never use the default transport.

* When a timeout error occurs save instead of drop data.

* Refactor trace_observer.go

* Move defer statement to follow conventions

* Refactor grpc.Dial logic. (newrelic#949)

* Enable GitHub Actions for CI testing.

* Add changelog entry.

* Update version for v3.7.0 (newrelic#956)

* Update version for v3.7.0

* Fix headings

* Modify Serverless to use a named pipe for telemetry when present

Serverless telemetry is normally sent to stdout. This is an alternate
path designed for use with an externally managed named pipe at a
fixed location.

* Changelog entry

* Formatting

* Fix failing go1.9 tests.

* Update CHANGELOG.md

Co-authored-by: Rey Abolofia <purple4reina@gmail.com>

* Address PR feedback

Co-authored-by: Rey Abolofia <rabolofia@newrelic.com>
Co-authored-by: Elizabeth Heinlein <eheinlein@newrelic.com>
Co-authored-by: Elizabeth Heinlein <52758187+newrelic-eheinlein@users.noreply.github.com>
Co-authored-by: Rey Abolofia <purple4reina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants