Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Aerospike in Datastore #233

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Adds Aerospike in Datastore #233

merged 1 commit into from
Mar 17, 2021

Conversation

krtkvrm
Copy link
Contributor

@krtkvrm krtkvrm commented Sep 21, 2020

This PR proposes to add Aerospike for Datastore Segment NR Transaction

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pyohannes
Copy link

Hi @vkartik97!

We are investigating adding this datastore. Thanks for opening this!

@jodeev jodeev added this to To Do in Go Engineering Board Oct 20, 2020
@jodeev jodeev moved this from To Do to In progress in Go Engineering Board Oct 21, 2020
@Miriam-R
Copy link
Contributor

Miriam-R commented Nov 5, 2020

Would we want to add this to the Go Agent or the OTel Agent @jodeev

@RichVanderwal RichVanderwal moved this from In progress to PM to triage in Go Engineering Board Nov 6, 2020
@jodeev jodeev closed this Nov 12, 2020
Go Engineering Board automation moved this from PM to triage to Done Nov 12, 2020
@jodeev jodeev reopened this Nov 13, 2020
Go Engineering Board automation moved this from Done to Triage Nov 13, 2020
@RichVanderwal RichVanderwal moved this from Triage to To Do in Go Engineering Board Dec 3, 2020
@RichVanderwal RichVanderwal added the p2 Priority 2 work items label Dec 3, 2020
@RichVanderwal
Copy link
Contributor

@jodeev would like to get this into the next release.

@RichVanderwal RichVanderwal self-assigned this Dec 3, 2020
@jodeev jodeev added this to the Mar Go agent release milestone Mar 11, 2021
@RichVanderwal RichVanderwal changed the base branch from master to develop March 17, 2021 23:25
RichVanderwal
RichVanderwal approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@RichVanderwal RichVanderwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vkartik97 , this looks good! I've switched this PR to be merged into newrelic:develop instead of newrelic:master. We're hoping to include this in the upcoming maintenance release for the Go Agent.

@RichVanderwal RichVanderwal merged commit b1271a4 into newrelic:develop Mar 17, 2021
Go Engineering Board automation moved this from To Do to Done Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichVanderwal RichVanderwal RichVanderwal approved these changes

Assignees

@RichVanderwal RichVanderwal

@jodeev jodeev

Labels
enhancement p2 Priority 2 work items
Projects
Go Engineering Board
Done
Milestone
Mar Go agent release
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@krtkvrm @CLAassistant @pyohannes @Miriam-R @RichVanderwal @jodeev