v3/integrations/nrawssdk-v2: Grab the NR Transaction from the Context when txn is not set #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging develop to create v3.13.0
|
|
|
@RichVanderwal Just wanted to bump this PR. We're currently pulling in our fork for our application, so I'm hoping we can get this (or something equivalent) merged sooner than later. Thanks! |
|
Thanks, @nc-wittj , I understand maintaining your own fork takes extra time and attention. We're working this into the plan for this month's release. |
|
@RichVanderwal cool, thanks! Just wanted to make sure it didn't slip through the cracks. 😄 |
RichVanderwal
previously approved these changes
Jul 2, 2021
RichVanderwal
approved these changes
Jul 2, 2021
RichVanderwal
added a commit
to RichVanderwal/go-agent
that referenced
this pull request
Jul 2, 2021
RichVanderwal
added a commit
that referenced
this pull request
Jul 2, 2021
example change to support PR #328, plus CHANGELOG.md
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
#288 (comment)
Details
Allows not needing to individually wrap each AWS API call, by just leveraging the context that is present in the middleware. This allows setting up the New Relic integration once with the AWS config, and any AWS client that uses that AWS config will be automatically integrated with New Relic.
Shoutout to @HenriBeck for noticing this!