Enable DT by Default for the Go Agent #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamemilio
reviewed
May 19, 2022
| @@ -14,14 +14,14 @@ import ( | |||
|
|
|||
| func doRequest(txn *newrelic.Transaction) error { | |||
| req, err := http.NewRequest("GET", "http://localhost:8000/segments", nil) | |||
| if nil != err { | |||
| if err != nil { | |||
There was a problem hiding this comment.
thanks for fixing this, these always bothered me
There was a problem hiding this comment.
As a matter of principle I've been fixing those as I encounter them. when doing other fixes.
| panic(err) | ||
| } | ||
| app.WaitForConnection(10 * time.Second) |
There was a problem hiding this comment.
Will this one-shot redis example work without that WaitForConnection in here?
RichVanderwal
approved these changes
May 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code enables DT by default for the Go agent.