-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding LICENSE.txt so the doc should be shown at pkg.go.dev #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 3.20.4
Co-authored-by: Emilio Garcia <iamemilio@users.noreply.github.com>
feature: instrument go-redis v9
…dis-v8 Revert "feature: instrument go-redis v9"
Release 3.21.0
iamemilio
approved these changes
Apr 5, 2023
auto assign bot 🤖
fix auto assign action
iamemilio
requested changes
Apr 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase this PR from the develop branch. There are some revert commits in master that are not in develop and they are causing all sorts of trouble. We are working on resolving that.
Update CI jobs to run on ubuntu-latest
egon12
force-pushed
the
pr/fix/missing_license
branch
from
April 19, 2023 01:22
cbd6cae
to
4ec3b5d
Compare
Sorry I miss the message. I've rebased it into develop, and push force into it. |
iamemilio
approved these changes
Apr 20, 2023
mirackara
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://pkg.go.dev/github.com/newrelic/go-agent/v3/integrations/nrpgx5 we got report that
The docs is not shown because
License: None detected not legal advice
In it's siblings folder https://pkg.go.dev/github.com/newrelic/go-agent/v3/integrations/nrpgx, there are already license
So the documentation is shown perfectly.
This commit will add the license so we can see the documentation in pkg.go.dev
Links
Details