Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding LICENSE.txt so the doc should be shown at pkg.go.dev #661

Merged
merged 14 commits into from
Apr 20, 2023

Conversation

egon12
Copy link
Contributor

@egon12 egon12 commented Apr 5, 2023

In https://pkg.go.dev/github.com/newrelic/go-agent/v3/integrations/nrpgx5 we got report that
The docs is not shown because License: None detected not legal advice

In it's siblings folder https://pkg.go.dev/github.com/newrelic/go-agent/v3/integrations/nrpgx, there are already license
So the documentation is shown perfectly.

This commit will add the license so we can see the documentation in pkg.go.dev

Links

Details

@iamemilio iamemilio changed the base branch from master to develop April 5, 2023 14:09
@iamemilio iamemilio self-requested a review April 7, 2023 18:26
Copy link
Contributor

@iamemilio iamemilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this PR from the develop branch. There are some revert commits in master that are not in develop and they are causing all sorts of trouble. We are working on resolving that.

@egon12
Copy link
Contributor Author

egon12 commented Apr 19, 2023

Sorry I miss the message. I've rebased it into develop, and push force into it.

@iamemilio iamemilio changed the base branch from develop to master April 20, 2023 15:42
@iamemilio iamemilio changed the base branch from master to develop April 20, 2023 15:42
@iamemilio iamemilio merged commit d03a7c3 into newrelic:develop Apr 20, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants