Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add logs-in-context example with logrus #778

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

Julien4218
Copy link
Contributor

Details

This is a variation of the existing example for http-server, adding the specific steps to enable logs-in-context with distributed tracing.

image

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@d59f46c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #778   +/-   ##
==========================================
  Coverage           ?   81.68%           
==========================================
  Files              ?      134           
  Lines              ?    12248           
  Branches           ?        0           
==========================================
  Hits               ?    10005           
  Misses             ?     1966           
  Partials           ?      277           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iamemilio iamemilio changed the base branch from master to develop September 11, 2023 17:45
@iamemilio iamemilio self-requested a review September 11, 2023 17:45
@iamemilio
Copy link
Contributor

rather than contribute this to v3/examples I think this would be a better fit for v3/integrations/logcontext-v2/nrlogrus/examples. Would you mind moving the file there? Thanks for contributing though, we are always happy to have more examples.

@Julien4218
Copy link
Contributor Author

rather than contribute this to v3/examples I think this would be a better fit for v3/integrations/logcontext-v2/nrlogrus/examples. Would you mind moving the file there? Thanks for contributing though, we are always happy to have more examples.

Sounds good, done.

@iamemilio
Copy link
Contributor

Once you sign the CLA we can merge this.

@Julien4218
Copy link
Contributor Author

Once you sign the CLA we can merge this.

Done, thank you.

@iamemilio iamemilio merged commit 0afb8ac into newrelic:develop Sep 12, 2023
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants