Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct references to PHP #32

Closed
wants to merge 1 commit into from
Closed

Conversation

bduranleau-nr
Copy link
Contributor

Description

Fixes incorrect references to PHP in PHP specific codepaths.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@bduranleau-nr bduranleau-nr requested review from a team May 28, 2024 16:23
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.75%. Comparing base (80b665b) to head (0a9721e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   60.75%   60.75%           
=======================================
  Files           7        7           
  Lines         586      586           
=======================================
  Hits          356      356           
  Misses        187      187           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bduranleau-nr
Copy link
Contributor Author

Superseded by #79

@bduranleau-nr bduranleau-nr deleted the fix/php-codepath-fixes branch October 3, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants