Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unit testing for package upgrade #36

Merged
merged 1 commit into from
May 30, 2024

Conversation

juanjjaramillo
Copy link
Contributor

Description

Unit testing for Go package upgrade

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.19%. Comparing base (6117899) to head (ba7077e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   47.37%   49.19%   +1.81%     
==========================================
  Files          12       13       +1     
  Lines         876      927      +51     
==========================================
+ Hits          415      456      +41     
- Misses        406      412       +6     
- Partials       55       59       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanjjaramillo juanjjaramillo marked this pull request as ready for review May 29, 2024 20:11
@juanjjaramillo juanjjaramillo requested a review from a team May 29, 2024 20:11
@juanjjaramillo juanjjaramillo merged commit b239208 into main May 30, 2024
10 checks passed
@juanjjaramillo juanjjaramillo deleted the juanjjaramillo/package_upgrade branch May 30, 2024 00:20
paologallinaharbur pushed a commit to paologallinaharbur/k8s-agents-operator that referenced this pull request Sep 6, 2024
* feat: add basic std logger

* feat: add trait for EventLogger

* feat: add tests for stdeventreceiver

* fix: fields spelling

* fix: apply clippy suggestions

* fix: conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants