fix: Certain Profiler log messages did not print correctly when running under Linux. (#2200) #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tippmar-nr
requested review from
a team,
jaffinito,
nrcventura,
nr-ahemsath,
chynesNR and
dotnet-agent-team-bot
Co-authored-by: tippmar-nr <tippmar-nr@users.noreply.github.com>
chynesNR
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with certain Profiler log messages that used the
_X()macro to convert a string. On Linux platforms, those messages would print out as an address (like0x7fc4e6afc77c) rather than the string content. Modifying the log messages to use theLprefix instead results in the messages printing correctly as expected.There may be a deeper issue, but there were only a handful of log messages using
_X()and I've changed the ones that might get emitted on Linux toLinstead.I also confirmed that this isn't an issue related to an old .NET Core version or an old Linux distro -- the test app I used to reproduce this issue behaved the same when built on the latest .NET SDK and Runtime.
Fixes #2200