Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mode to output grouped logs using GHA syntax #14

Merged
merged 5 commits into from
Feb 2, 2022
Merged

Conversation

nadiamoe
Copy link
Contributor

@nadiamoe nadiamoe commented Feb 1, 2022

This PR uses the group log GHA commands to wrap the output of before and after commands under a nice collapser when running in GHA. Moreover, newlines and special characters are no longer escaped.

A new entry in the test spec, plain_logs, have been added to opt-out of this behavior.

@nadiamoe nadiamoe requested a review from a team February 1, 2022 15:21
Copy link
Contributor

@gsanchezgavier gsanchezgavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using this capability looks great!! , I couldn't find an example working in the self test, did you make it work for any of those?

newrelic-integration-e2e/internal/runtime/runner.go Outdated Show resolved Hide resolved
@nadiamoe nadiamoe force-pushed the unscaped-logs branch 4 times, most recently from 2f9de4c to 9758b39 Compare February 1, 2022 18:23
@nadiamoe nadiamoe force-pushed the unscaped-logs branch 3 times, most recently from 128ae09 to 124d292 Compare February 2, 2022 11:10
@nadiamoe nadiamoe force-pushed the unscaped-logs branch 3 times, most recently from d819e45 to 00f9c58 Compare February 2, 2022 13:53
Copy link
Contributor

@gsanchezgavier gsanchezgavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvements !

@nadiamoe nadiamoe merged commit 850b60c into main Feb 2, 2022
@nadiamoe nadiamoe deleted the unscaped-logs branch February 2, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants