Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Product Partnerships] [Project Sleek] Updated Project Configurations For EKS Add-ons #63

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

[Product Partnerships] [Project Sleek] Updated Project Configurations For EKS Add-ons #63

wants to merge 25 commits into from

Conversation

rahul188
Copy link

@rahul188 rahul188 commented Sep 28, 2023 •
edited

We've taken steps to update files related to secrets & NewRelic-licence-key

  • Specifically, we have securely removed the below files -
    • aws_mp_configuration_schema.json
    • secrets.yaml
    • values.schema.json.
  • Additionally, we've updated the version information in chart.yml to ensure accurate tracking of our application's state.
  • In an effort to streamline our configurations, we've also eliminated unnecessary parameters from values.yml.

juanjjaramillo
juanjjaramillo suggested changes Oct 6, 2023
View reviewed changes
charts/newrelic-k8s-operator/templates/secrets.yaml
@@ -1,13 +0,0 @@
apiVersion: v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahul188 :

  1. Can you please document why you are deleting this file?
  2. What is the alternative that replaces the use of this file?

charts/newrelic-k8s-operator/values.yaml Outdated Show resolved Hide resolved
charts/newrelic-k8s-operator/values.yaml Outdated Show resolved Hide resolved
juanjjaramillo
juanjjaramillo suggested changes Oct 7, 2023
View reviewed changes
charts/newrelic-k8s-operator/Chart.yaml Outdated
@@ -21,7 +21,7 @@ type: application
# time you make changes to the chart and its templates, including the app
# version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.4
version: 0.1.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahul188 please remove this entry. We now have in place automated releases for this repo. You will also need to rebase your branch since we now enforce that branches have to be up to date before merging

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanjjaramillo, we have onboarded to EKS with this version that is why there is necessity to update the version here. i suppose there is no pipeline between AWS & current repo which can update the version automatically.

aj-NR and others added 20 commits October 19, 2023 15:17
@aj-NR
Reverting values.yaml as discussed with Jerry & Mikhail
fb9cd0e
@juanjjaramillo @aj-NR
ci: Introduce CHANGELOG.md (newrelic#66)
0555a26 
Introduce CHANGELOG.md to keep track of repo changes
@juanjjaramillo @aj-NR
ci: Add pull request template (newrelic#67)
708bd18
@juanjjaramillo @aj-NR
ci: Add 'changelog' workflow (newrelic#68)
04f2bef 
## Description
<!-- Please include a summary of the change in your PR and what it's
fixing. -->
Enforce changelog changes in PRs

## Type of change
<!-- Please check the relevant option. -->

- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] New feature / enhancement (non-breaking change which adds
functionality)
- [ ] Security fix
- [ ] Bug fix (non-breaking change which fixes an issue)

## Checklist:
<!-- Please check applicable options. -->

- [x] Add changelog entry following the [contributing
guide](../CONTRIBUTING.md#pull-requests)
- [ ] Documentation has been updated
- [ ] This change requires changes in testing:
  - [ ] unit tests
  - [ ] E2E tests
@juanjjaramillo @aj-NR
ci: Enable automatic release (newrelic#69)
5c20b1f 
## Description
<!-- Please include a summary of the change in your PR and what it's
fixing. -->
Enable automatic release

## Type of change
<!-- Please check the relevant option. -->

- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] New feature / enhancement (non-breaking change which adds
functionality)
- [ ] Security fix
- [ ] Bug fix (non-breaking change which fixes an issue)

## Checklist:
<!-- Please check applicable options. -->

- [x] Add changelog entry following the [contributing
guide](../CONTRIBUTING.md#pull-requests)
- [ ] Documentation has been updated
- [ ] This change requires changes in testing:
  - [ ] unit tests
  - [ ] E2E tests
@renovate @aj-NR
chore(deps): update alpine docker tag to v3.18.4 (newrelic#51)
d2e6874 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| alpine | final | patch | `3.18.2` -> `3.18.4` |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/newrelic/newrelic-k8s-operator).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNy4xIiwidXBkYXRlZEluVmVyIjoiMzcuMC4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @aj-NR
chore(deps): update actions/checkout action to v4 (newrelic#58)
ae40259 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/checkout](https://github.com/actions/checkout) | action |
major | `v3` -> `v4` |

---

### Release Notes

<details>
<summary>actions/checkout (actions/checkout)</summary>

###
[`v4`](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v400)

[Compare Source](https://github.com/actions/checkout/compare/v3...v4)

- [Support fetching without the --progress
option](https://github.com/actions/checkout/pull/1067)
-   [Update to node20](https://github.com/actions/checkout/pull/1436)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/newrelic/newrelic-k8s-operator).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi43OC44IiwidXBkYXRlZEluVmVyIjoiMzYuNzguOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@juanjjaramillo @aj-NR
Correct broken docs link (newrelic#54)
4c963e4 
Co-authored-by: Juan Jose Jaramillo <juanjjaramillo@yahoo.com>
@renovate @juanjjaramillo @aj-NR
chore(deps): update golang version (newrelic#70)
ea2c2d8 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [go](https://go.dev/) ([source](https://github.com/golang/go)) |
golang | minor | `1.20` -> `1.21` |
| golang | stage | minor | `1.20-alpine` -> `1.21-alpine` |

---

### Release Notes

<details>
<summary>golang/go (go)</summary>

###
[`v1.21.2`](https://github.com/golang/go/compare/go1.21.1...go1.21.2)

###
[`v1.21.1`](https://github.com/golang/go/compare/go1.21.0...go1.21.1)

###
[`v1.21.0`](https://github.com/golang/go/compare/go1.20.8...go1.21.0)

###
[`v1.20.9`](https://github.com/golang/go/compare/go1.20.8...go1.20.9)

###
[`v1.20.8`](https://github.com/golang/go/compare/go1.20.7...go1.20.8)

###
[`v1.20.7`](https://github.com/golang/go/compare/go1.20.6...go1.20.7)

###
[`v1.20.6`](https://github.com/golang/go/compare/go1.20.5...go1.20.6)

###
[`v1.20.5`](https://github.com/golang/go/compare/go1.20.4...go1.20.5)

###
[`v1.20.4`](https://github.com/golang/go/compare/go1.20.3...go1.20.4)

###
[`v1.20.3`](https://github.com/golang/go/compare/go1.20.2...go1.20.3)

###
[`v1.20.2`](https://github.com/golang/go/compare/go1.20.1...go1.20.2)

###
[`v1.20.1`](https://github.com/golang/go/compare/go1.20...go1.20.1)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/newrelic/newrelic-k8s-operator).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Juan Jose Jaramillo <juanjjaramillo@yahoo.com>
@renovate @juanjjaramillo @aj-NR
fix(deps): update module github.com/onsi/gomega to v1.28.0 (newrelic#50)
e40bae8 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/onsi/gomega](https://github.com/onsi/gomega) | require |
minor | `v1.27.8` -> `v1.28.0` |

---

### Release Notes

<details>
<summary>onsi/gomega (github.com/onsi/gomega)</summary>

### [`v1.28.0`](https://github.com/onsi/gomega/releases/tag/v1.28.0)

[Compare
Source](https://github.com/onsi/gomega/compare/v1.27.10...v1.28.0)

#### 1.28.0

##### Features

- Add VerifyHost handler to ghttp
([#&#8203;698](https://github.com/onsi/gomega/issues/698))
\[[`0b03b36`](https://github.com/onsi/gomega/commit/0b03b36)]

##### Fixes

- Read Body for Newer Responses in HaveHTTPBodyMatcher
([#&#8203;686](https://github.com/onsi/gomega/issues/686))
\[[`18d6673`](https://github.com/onsi/gomega/commit/18d6673)]

##### Maintenance

- Bump github.com/onsi/ginkgo/v2 from 2.11.0 to 2.12.0
([#&#8203;693](https://github.com/onsi/gomega/issues/693))
\[[`55a33f3`](https://github.com/onsi/gomega/commit/55a33f3)]
- Typo in matchers.go
([#&#8203;691](https://github.com/onsi/gomega/issues/691))
\[[`de68e8f`](https://github.com/onsi/gomega/commit/de68e8f)]
- Bump commonmarker from 0.23.9 to 0.23.10 in /docs
([#&#8203;690](https://github.com/onsi/gomega/issues/690))
\[[`ab17f5e`](https://github.com/onsi/gomega/commit/ab17f5e)]
- chore: update test matrix for Go 1.21
([#&#8203;689](https://github.com/onsi/gomega/issues/689))
\[[`5069017`](https://github.com/onsi/gomega/commit/5069017)]
- Bump golang.org/x/net from 0.12.0 to 0.14.0
([#&#8203;688](https://github.com/onsi/gomega/issues/688))
\[[`babe25f`](https://github.com/onsi/gomega/commit/babe25f)]

### [`v1.27.10`](https://github.com/onsi/gomega/releases/tag/v1.27.10)

[Compare
Source](https://github.com/onsi/gomega/compare/v1.27.9...v1.27.10)

#### 1.27.10

##### Fixes

- fix: go 1.21 adding goroutine ID to creator+location
([#&#8203;685](https://github.com/onsi/gomega/issues/685))
\[[`bdc7803`](https://github.com/onsi/gomega/commit/bdc7803)]

###
[`v1.27.9`](https://github.com/onsi/gomega/compare/v1.27.8...v1.27.9)

[Compare
Source](https://github.com/onsi/gomega/compare/v1.27.8...v1.27.9)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/newrelic/newrelic-k8s-operator).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzcuMC4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Juan Jose Jaramillo <juanjjaramillo@yahoo.com>
@renovate @aj-NR
fix(deps): update module github.com/onsi/ginkgo/v2 to v2.12.1 (newrel…
bf6d20d 
…ic#41)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) |
require | patch | `v2.12.0` -> `v2.12.1` |

---

### Release Notes

<details>
<summary>onsi/ginkgo (github.com/onsi/ginkgo/v2)</summary>

### [`v2.12.1`](https://github.com/onsi/ginkgo/releases/tag/v2.12.1)

[Compare
Source](https://github.com/onsi/ginkgo/compare/v2.12.0...v2.12.1)

#### 2.12.1

##### Fixes

- Print logr prefix if it exists
([#&#8203;1275](https://github.com/onsi/ginkgo/issues/1275))
\[[`90d4846`](https://github.com/onsi/ginkgo/commit/90d4846)]

##### Maintenance

- Bump actions/checkout from 3 to 4
([#&#8203;1271](https://github.com/onsi/ginkgo/issues/1271))
\[[`555f543`](https://github.com/onsi/ginkgo/commit/555f543)]
- Bump golang.org/x/sys from 0.11.0 to 0.12.0
([#&#8203;1270](https://github.com/onsi/ginkgo/issues/1270))
\[[`d867b7d`](https://github.com/onsi/ginkgo/commit/d867b7d)]

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/newrelic/newrelic-k8s-operator).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMDIuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@juanjjaramillo @aj-NR
fix: Fix repolinter error (newrelic#71)
8b58b78 
## Description
<!-- Please include a summary of the change in your PR and what it's
fixing. -->

## Type of change
<!-- Please check the relevant option. -->

- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] New feature / enhancement (non-breaking change which adds
functionality)
- [ ] Security fix
- [x] Bug fix (non-breaking change which fixes an issue)

## Checklist:
<!-- Please check applicable options. -->

- [ ] Add changelog entry following the [contributing
guide](../CONTRIBUTING.md#pull-requests)
- [ ] Documentation has been updated
- [ ] This change requires changes in testing:
  - [ ] unit tests
  - [ ] E2E tests
@AmitBenAmi @juanjjaramillo @aj-NR
fix(rbac): adding the patch operation for operators.coreos.com (n…
09aa3e1 
…ewrelic#56)

The `patch` operation was missing, causing numerous errors in the
operator in the form of:
```
newrelic-k8s-operator-controller-manager-6b4487bb-mk2cc manager 2023-08-23T15:35:31Z	ERROR	Reconciler error	{"controller": "nribundle-controller", "object": {"name":"nribundle","namespace":"newrelic"}, "namespace": "newrelic", "name": "nribundle", "reconcileID": "0343110a-3310-4d93-a7d8-07b4009df98e", "error": "patch error: catalogsources.operators.coreos.com \"pixie-operator-index\" is forbidden: User \"system:serviceaccount:newrelic:newrelic-k8s-operator-controller-manager\" cannot patch resource \"catalogsources\" in API group \"operators.coreos.com\" in the namespace \"px-operator\""}
newrelic-k8s-operator-controller-manager-6b4487bb-mk2cc manager sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
newrelic-k8s-operator-controller-manager-6b4487bb-mk2cc manager 	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.1/pkg/internal/controller/controller.go:329
newrelic-k8s-operator-controller-manager-6b4487bb-mk2cc manager sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
newrelic-k8s-operator-controller-manager-6b4487bb-mk2cc manager 	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.1/pkg/internal/controller/controller.go:274
newrelic-k8s-operator-controller-manager-6b4487bb-mk2cc manager sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
newrelic-k8s-operator-controller-manager-6b4487bb-mk2cc manager 	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.1/pkg/internal/controller/controller.go:235
```

fixes newrelic#55

---------

Signed-off-by: Amit Ben Ami <benami.amit1@gmail.com>
Co-authored-by: Juan Jose Jaramillo <juanjjaramillo@yahoo.com>
@NewRelic-K8s-Agents-Bot @aj-NR
Update changelog with changes from v0.1.0
2361883
@juanjjaramillo @aj-NR
feat: Sync versions between app image and Helm chart to ease customer…
0d27611 
… inception (newrelic#73)

## Description
<!-- Please include a summary of the change in your PR and what it's
fixing. -->
It is hard to track the mapping between `version` and `appVersion` on a
Helm chart. By triggering a new image release, we are forcing that the
next chart release will sync both versions to be the same.

## Type of change
<!-- Please check the relevant option. -->

- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] New feature / enhancement (non-breaking change which adds
functionality)
- [ ] Security fix
- [ ] Bug fix (non-breaking change which fixes an issue)

## Checklist:
<!-- Please check applicable options. -->

- [x] Add changelog entry following the [contributing
guide](../CONTRIBUTING.md#pull-requests)
- [x] Documentation has been updated
- [ ] This change requires changes in testing:
  - [ ] unit tests
  - [ ] E2E tests
@NewRelic-K8s-Agents-Bot @aj-NR
Update changelog with changes from v0.2.0
22f55fe
@github-actions @juanjjaramillo @aj-NR
Bump version and update docs (newrelic#74)
ce64efa 
Bump version and appVersion and results of running helm docs as part of
release automation.

Co-authored-by: juanjjaramillo <juanjjaramillo@users.noreply.github.com>
@renovate @aj-NR
fix(deps): update module github.com/onsi/ginkgo/v2 to v2.13.0
24b1194
@NewRelic-K8s-Agents-Bot @aj-NR
Update changelog with changes from v0.2.1
c32137f
@svetlanabrennan @aj-NR
Update release.yml
5317e74
@CLAassistant
Copy link

CLAassistant commented Oct 19, 2023 •
edited

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 8 committers have signed the CLA.

✅ aj-NR
✅ rahul188
✅ juanjjaramillo
✅ lazyplatypus
✅ AmitBenAmi
✅ svetlanabrennan
✅ NewRelic-K8s-Agents-Bot
❌ renovate[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@rahul188 rahul188 changed the title [Product Partnerships] [Project Sleek] Updated Project Configurations [Product Partnerships] [Project Sleek] Updated Project Configurations For EKS Add-ons Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj-NR aj-NR aj-NR left review comments

@xqi-nr xqi-nr xqi-nr left review comments

@juanjjaramillo juanjjaramillo juanjjaramillo requested changes

@svetlanabrennan svetlanabrennan Awaiting requested review from svetlanabrennan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rahul188 @CLAassistant @juanjjaramillo @aj-NR @xqi-nr @AmitBenAmi @NewRelic-K8s-Agents-Bot @svetlanabrennan