Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeouts #206

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Add timeouts #206

merged 5 commits into from
Apr 17, 2024

Conversation

chaudharysaket
Copy link
Contributor

@chaudharysaket chaudharysaket commented Apr 12, 2024

Extension taking more than 2 minutes when in VPC without outbound traffic.

  • Added timeout for calls to Secret & SSM Parameter Store
  • Added context timeout for Sanity check calls for Secret and SSM Parameter Store
  • Reduced timeout for github agent version check call to 2 seconds

main.go Outdated
@@ -86,7 +86,10 @@ func main() {
}

// Attempt to find the license key for telemetry sending
licenseKey, err := credentials.GetNewRelicLicenseKey(ctx, conf)
var timeout = 5 * time.Second
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 5 seconds is a really long time. Maybe 1 second is appropriate here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified to 1 second in the revision. Thanks!

@chaudharysaket chaudharysaket changed the title [review] licenseKey call timeout Add timeouts Apr 16, 2024
@iamemilio
Copy link
Contributor

LGTM, thanks!

@chaudharysaket chaudharysaket merged commit cf86fb5 into newrelic:main Apr 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants