Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

next.js: Update instrumentation to construct specs at instrumentation level #172

Closed
bizob2828 opened this issue Feb 22, 2024 · 1 comment · Fixed by #174
Closed

next.js: Update instrumentation to construct specs at instrumentation level #172

bizob2828 opened this issue Feb 22, 2024 · 1 comment · Fixed by #174
Assignees
@bizob2828
Labels
points: 3 A few days

Comments

@bizob2828
Copy link
Member

Is your feature request related to a problem? Please describe.

Instrumentation using shim should instantiate the relevant spec type and not rely on the shim helpers to do this. Another indicator is the instrumentation that uses shim should no longer return object literals with various keys.

Additional context

This cannot be completely merged until the agent has a released for #2036
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-231737

@bizob2828 bizob2828 mentioned this issue Feb 22, 2024
Closed
@bizob2828 bizob2828 assigned bizob2828 and unassigned bizob2828 Feb 22, 2024
@kmudduluru kmudduluru added risk: medium This change impacts senstive areas or has other traits that warrant more careful consideration. and removed needs-triage risk: medium This change impacts senstive areas or has other traits that warrant more careful consideration. labels Feb 26, 2024
@kmudduluru kmudduluru added the points: 3 A few days label Mar 4, 2024
@bizob2828 bizob2828 self-assigned this Mar 5, 2024
@bizob2828 bizob2828 mentioned this issue Mar 7, 2024
Merged
@bizob2828 bizob2828 moved this to Done: Issues recently completed in Node.js Engineering Board Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bizob2828 bizob2828

Labels
points: 3 A few days
Projects
Node.js Engineering Board
Archived in project
Milestone
No milestone
2 participants
@bizob2828 @kmudduluru