This repository has been archived by the owner on Jul 31, 2024. It is now read-only.
refactor: Updated instrumentation to construct spec objects at instrumentation #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 93.04% 93.23% +0.19%
==========================================
Files 4 4
Lines 273 281 +8
==========================================
+ Hits 254 262 +8
Misses 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mrickard
approved these changes
Mar 7, 2024
Merged
bizob2828
added a commit
to bizob2828/newrelic-node-nextjs
that referenced
this pull request
Jul 26, 2024
refactor: Updated instrumentation to construct spec objects at instrumentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Release Notes
Links
Closes #172
Details
Aside from updating instrumentation to pass in specs I realized that we were assigning query params in instrumentation. They were getting assigned as
route.parameters.route.<query-param-key>. This is incorrect and the query parameters were automatically getting assigned from parsing the url at transaction end. I also updated the minimum agent version to 11.12.0 asshim.specsneeds to be present.