This repository has been archived by the owner on Jul 31, 2024. It is now read-only.
updated example of injecting browser agent #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrickard
reviewed
Sep 9, 2022
README.md
Outdated
| @@ -131,7 +144,7 @@ Error.getInitialProps = ({ res, err }) => { | |||
| export default Error; | |||
| ``` | |||
|
|
|||
| The example above assumes that both the New Relic Browser and Node.js agents are integrated. `getInitialProps` function's `if` statement checks whether an error was thrown on the server side (`typeof window === "undefined"`) and if it was the case, it `requires` New Relic Node.js agent and sends an `err` with `noticeError` method. Otherwise it assumes the error was thrown on the front-end side, and uses the browser agent to send the error to New Relic by using `window.newrelic.noticeError(err)`. | |||
| The example above assumes that both the New Relic Browser and Node.js agents are [integrated](#client-side-instrumentation). `getInitialProps` function's `if` statement checks whether an error was thrown on the server side (`typeof window === "undefined"`) and if it was the case, it `requires` New Relic Node.js agent and sends an `err` with `noticeError` method. Otherwise it assumes the error was thrown on the front-end side, and uses the browser agent to send the error to New Relic by using `window.newrelic.noticeError(err)`. | |||
There was a problem hiding this comment.
For clarity, I think I'd prefer
The getInitialProps function's if statement
to not having the initial "The."
There was a problem hiding this comment.
The American Mathematical Society's style guide recommends not beginning a sentence with a symbol. I think that helps reading, because the eyes use both punctuation and capitalisation to see a new sentence. I bet our doc writers have similar ideas.
There was a problem hiding this comment.
took me a while to figure out the ask here but updated!
mrickard
previously approved these changes
Sep 9, 2022
mrickard
approved these changes
Sep 12, 2022
Merged
bizob2828
added a commit
to bizob2828/newrelic-node-nextjs
that referenced
this pull request
Jul 26, 2024
…ample updated example of injecting browser agent
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Release Notes
Links
Details