feat: Support "minSupported" in target definition #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
reviewed
Sep 16, 2024
| for _, test := range pkg.Tests { | ||
| if test.Supported == false { | ||
| continue | ||
| if target.MinSupported == "" { |
There was a problem hiding this comment.
this must now be present. i was thinking of only including it when needed. I think that's why this PR removed some files newrelic/node-newrelic#2581
There was a problem hiding this comment.
Future readers: this is incorrect. The issue was that a target did not have a minSupported attribute and was not listed in the tests. When we encounter an error parsing a versioned test manifest, we omit all of the data in that manifest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for reading the minimum supported version of a module from the
targetsarray.Also updates deps.