Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument s3transfer BoundExecutor submit function. #1185

Merged
merged 8 commits into from
Aug 8, 2024

Conversation

umaannamalai
Copy link
Contributor

@umaannamalai umaannamalai commented Jul 29, 2024

This PR instruments the Instrument s3transfer BoundExecutor submit function. This supports context propagation so that the agent is able to instrument upload_file in boto3.

Closes #1178.

umaannamalai and others added 3 commits July 29, 2024 16:36
Co-authored-by: Tim Pansino <tpansino@newrelic.com>
Co-authored-by: Lalleh Rafeei <lrafeei@newrelic.com>
Co-authored-by: Hannah Stepanek <hstepanek@newrelic.com>
Co-authored-by: Tim Pansino <tpansino@newrelic.com>
Co-authored-by: Lalleh Rafeei <lrafeei@newrelic.com>
Co-authored-by: Hannah Stepanek <hstepanek@newrelic.com>
@umaannamalai umaannamalai requested a review from a team July 29, 2024 23:41
Copy link

github-actions bot commented Jul 29, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 2 0 5.32s
✅ PYTHON black 4 0 0 1.73s
❌ PYTHON flake8 4 2 0.99s
✅ PYTHON isort 4 1 0 0.37s
✅ PYTHON pylint 4 0 6.5s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.63%. Comparing base (772adec) to head (8d0c705).
Report is 2 commits behind head on main.

Files Patch % Lines
newrelic/hooks/external_s3transfer.py 78.57% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1185      +/-   ##
==========================================
+ Coverage   81.40%   81.63%   +0.23%     
==========================================
  Files         196      197       +1     
  Lines       21735    21750      +15     
  Branches     3795     3797       +2     
==========================================
+ Hits        17693    17756      +63     
+ Misses       2937     2889      -48     
  Partials     1105     1105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lrafeei
lrafeei previously approved these changes Jul 30, 2024
@umaannamalai umaannamalai added this to the v9.13.0 milestone Aug 8, 2024
@umaannamalai umaannamalai requested a review from a team as a code owner August 8, 2024 20:11
@mergify mergify bot removed the tests-failing label Aug 8, 2024
@lrafeei lrafeei merged commit 6c870ec into main Aug 8, 2024
51 of 52 checks passed
@lrafeei lrafeei deleted the instrument-s3transfer branch August 8, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boto3 not instrumented
4 participants