Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix database instance metric bug #905

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Fix database instance metric bug #905

merged 3 commits into from
Aug 18, 2023

Commits on Aug 17, 2023

  1. Remove enable_datastore_instance_feature 

    This was added in 2016 when the database instance feature was first developed. It
appears to be a method of gating this feature internally within the agent at the time
that it was implemented. However, it is not needed now and database instrumentations
that don't call this are actually broken in that the metric that is used to create the
service map (namely `Datastore/instance/MySQL/<host>/<port>`) does not get created due
to not calling this enable feature function.
    @hmstepanek
    hmstepanek committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    a64024b View commit details
    Browse the repository at this point in the history

  2. Rename cross agent test

    @hmstepanek
    hmstepanek committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    4228128 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Add Database/instance metric check

    @hmstepanek
    hmstepanek committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    25d8f7e View commit details
    Browse the repository at this point in the history