Correctly identify Unicorn when used with Rack v3 #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With version 3.0.0 of Rack in play, the agent can be fooled into thinking that web dispatching duties are being handled by Webrick. This is because the agent performs a less strict test for Webrick compared to other dispatchers; checking only for the existence of related namespaces to be defined. With these changes, the agent will now treat Webrick as the last dispatcher checked after all other anticipated production use dispatchers have not been located. Specifically, this means that Webrick is checked after Unicorn, Rainbows, and FastCGI; all of which may have been incorrectly reporting as having Webrick as the dispatcher if Rack v3.0.0 was being used. Resolves #1394
remove extra space character being used for unrelated RuboCop testing
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With version 3.0.0 of Rack in play, the agent can be fooled into thinking that web dispatching duties are being handled by Webrick. This is because the agent performs a less strict test for Webrick compared to other dispatchers; checking only for the existence of related namespaces to be defined.
With these changes, the agent will now treat Webrick as the last dispatcher checked after all other anticipated production use dispatchers have not been located. Specifically, this means that Webrick is checked after Unicorn, Rainbows, and FastCGI; all of which may have been incorrectly reporting as having Webrick as the dispatcher if Rack v3.0.0 was being used.
Resolves #1394