Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Feature: Add ability to gracefully shutdown the harvester. #26

Open
carlosroman opened this issue Aug 10, 2020 · 2 comments · May be fixed by #20
Open

Feature: Add ability to gracefully shutdown the harvester. #26

carlosroman opened this issue Aug 10, 2020 · 2 comments · May be fixed by #20
Projects
Go Engineering Board

Comments

@carlosroman
Copy link

Currently the harvester runs a go routine with tick that will tick forever. It would be good to be able to stop the ticker when the harvester is no longer needed.
@carlosroman carlosroman linked a pull request Aug 10, 2020 that will close this issue
Open
@jodeev jodeev added this to Triage in Go Engineering Board Jan 14, 2021
@Miriam-R
Copy link

Next steps: Make sure there's a shutdown event in our harvester for the Telemetry SDK.

@RichVanderwal
Copy link
Contributor

RichVanderwal commented Feb 18, 2021 •
edited
Loading

Currently, I believe the caller should call HarvestNow() to make sure all the data is sent, and it's just assumed the ticker will stop due to the whole application shutting down. Here's what happens in the New Relic OpenTelemetry Exporter:
https://github.com/newrelic/opentelemetry-exporter-go/blob/7c24e335d64821f6aaec96e1c48d478bcb290d70/newrelic/exporter.go#L205
No mention of stopping a ticker. We should stop the ticker when Exporter.Shutdown() is called.

@Miriam-R Miriam-R moved this from Triage to To Do in Go Engineering Board Feb 18, 2021
@jodeev jodeev moved this from To Do to Backlog in Go Engineering Board Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
Go Engineering Board
Ice Box
Milestone
No milestone
3 participants
@carlosroman @RichVanderwal @Miriam-R