Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

feat: added ability to configure SDK client to use an external context #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carlosroman
Copy link

@carlosroman carlosroman commented Aug 6, 2020

At the moment there is no way to stop the harvester from running as it uses its own background context. Added a new config variable so a context can be passed to the client. The "tick" in harvester.harvestRoutine can now be cancelled by the user.

This resolves #26.

@jodeev jodeev added this to To Do in Go Engineering Board Dec 17, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Feature: Add ability to gracefully shutdown the harvester.
2 participants