Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert test/unit/environment.test.js to tap #1703

Closed
mrickard opened this issue Jun 27, 2023 · 1 comment · Fixed by #1705
Closed

Convert test/unit/environment.test.js to tap #1703

mrickard opened this issue Jun 27, 2023 · 1 comment · Fixed by #1705
Assignees
@mrickard
Labels
dev:tests Indicates only changes to tests enhancement ready for review
Projects
Node.js Engineering Board

Comments

@mrickard
Copy link
Member

test/unit/environment.test.js uses mocha/chai assertions; it should be rewritten as tap.
@mrickard mrickard added enhancement dev:tests Indicates only changes to tests labels Jun 27, 2023
@workato-integration
Copy link

https://issues.newrelic.com/browse/NR-139427

@mrickard mrickard self-assigned this Jun 27, 2023
@newrelic-node-agent-team newrelic-node-agent-team added this to Triage Needed: Unprioritized Features in Node.js Engineering Board Jun 27, 2023
@mrickard mrickard mentioned this issue Jun 29, 2023
Merged
@mrickard mrickard moved this from Triage Needed: Unprioritized Features to Needs PR Review in Node.js Engineering Board Jun 29, 2023
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrickard mrickard

Labels
dev:tests Indicates only changes to tests enhancement ready for review
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(test): converted environment.test.js to tap mrickard/node-newrelic
1 participant
@mrickard