chore(test): converted environment.test.js to tap #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase this? The aws sdk work has been fixed |
bizob2828
approved these changes
Jun 30, 2023
|
@bizob2828 Sure--hang on a sec and I'll rebase. |
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
mrickard
force-pushed
the
NR-139427/environment.test-to-tap
branch
from
2459877
to
5094558
Compare
Codecov Report
@@ Coverage Diff @@
## main #1705 +/- ##
=======================================
Coverage 96.87% 96.87%
=======================================
Files 200 200
Lines 39181 39181
Branches 24 24
=======================================
Hits 37956 37956
Misses 1225 1225
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Jun 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converted tests/unit/environment.test.js to tap-style.
Related Issues
Closes #1703
Closes NR-139427