Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added supportability metrics to indicate how agent was loaded and if --enable-source-maps was passed to Node.js runtime #1657

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

bizob2828
Copy link
Member

Description

I still need to add the new metrics to angler. I also plan to layer on this and add more unit tests for index.js as we have some important branches not covered and the necessary mocks wired up to do the testing.

Links

Closes #1607

…s well as if --enable-source-maps was passed to node runtime
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #1657 (e3a4602) into main (c85c006) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1657      +/-   ##
==========================================
- Coverage   96.76%   96.65%   -0.11%     
==========================================
  Files         200      200              
  Lines       39083    39148      +65     
  Branches       24       22       -2     
==========================================
+ Hits        37818    37840      +22     
- Misses       1265     1308      +43     
Flag Coverage Δ
esm-unit-tests-14.x ?
esm-unit-tests-16.x ?
esm-unit-tests-18.x 92.11% <ø> (ø)
integration-tests-14.x ?
integration-tests-16.x ?
integration-tests-18.x 79.09% <92.53%> (+0.01%) ⬆️
unit-tests-14.x 91.32% <100.00%> (+0.01%) ⬆️
unit-tests-16.x 91.38% <100.00%> (+0.01%) ⬆️
unit-tests-18.x 91.36% <100.00%> (+0.01%) ⬆️
versioned-tests-14.x ?
versioned-tests-16.x ?
versioned-tests-18.x 76.93% <92.53%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
index.js 84.86% <100.00%> (+4.75%) ⬆️
lib/metrics/names.js 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmartin4563 jmartin4563 self-assigned this Jun 1, 2023
index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@bizob2828 bizob2828 merged commit 6f6f7e6 into newrelic:main Jun 5, 2023
@github-actions github-actions bot mentioned this pull request Jun 5, 2023
@bizob2828 bizob2828 deleted the add-moar-metrics branch August 28, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add supportability metric for source map support
2 participants