-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release v10.3.2 #1701
chore: release v10.3.2 #1701
Conversation
NEWS.md
Outdated
#### Security Improvements | ||
|
||
* **deps:** bump fast-xml-parser and @aws-sdk/client-lambda ([#1697](https://github.com/newrelic/node-newrelic/pull/1697)) ([4376584](https://github.com/newrelic/node-newrelic/commit/437658415a2869ed4236fa31b57128bb9807a2f3)) | ||
* Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we want these secondary lines. they don't provide any useful information to our customers. can you remove in all the items in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'd noticed that the bots were including signed commits, which is a small annoyance.
NEWS.md
Outdated
|
||
#### Miscellaneous Chores | ||
|
||
* **deps:** Updated security agent to v0.1.3 ([#1696](https://github.com/newrelic/node-newrelic/pull/1696)) ([0f957bd](https://github.com/newrelic/node-newrelic/commit/0f957bd0e39a32614337b5ade33f07d9729f1897)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also this was a security update right? If so, make sure you also edit the changelog.json to move this into the security section
Signed-off-by: mrickard <maurice@mauricerickard.com>
"version": "10.3.2", | ||
"changes": { | ||
"security": [ | ||
"bump fast-xml-parser and @aws-sdk/client-lambda" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the security fix was the security agent bumping semver, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the security agent mention on the new line 8 include a mention of semver explicitly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. This is a confusing one esp since the client-lambda was only updated in our repo, but due to semver ranges it'd be fine. so really that one doesn't need to be included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also looking at the security agent PR they did more than bump semver newrelic/csec-node-agent#59
Signed-off-by: mrickard <maurice@mauricerickard.com>
Codecov Report
@@ Coverage Diff @@
## main #1701 +/- ##
=======================================
Coverage 96.87% 96.87%
=======================================
Files 200 200
Lines 39181 39181
Branches 24 24
=======================================
Hits 37956 37956
Misses 1225 1225
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
v10.3.2 (2023-06-26)
Bug Fixes
Security Improvements
Miscellaneous Chores