Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v10.3.2 #1701

Merged
merged 4 commits into from
Jun 26, 2023
Merged

chore: release v10.3.2 #1701

merged 4 commits into from
Jun 26, 2023

Conversation

github-actions[bot]
Copy link
Contributor

v10.3.2 (2023-06-26)

Bug Fixes

  • prisma: check for query args in string property (#1684) (8d9b176)

Security Improvements

  • deps: bump fast-xml-parser and @aws-sdk/client-lambda (#1697) (4376584)
    • Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Miscellaneous Chores

@mrickard mrickard closed this Jun 26, 2023
@mrickard mrickard reopened this Jun 26, 2023
@mrickard mrickard marked this pull request as ready for review June 26, 2023 19:36
NEWS.md Outdated
#### Security Improvements

* **deps:** bump fast-xml-parser and @aws-sdk/client-lambda ([#1697](https://github.com/newrelic/node-newrelic/pull/1697)) ([4376584](https://github.com/newrelic/node-newrelic/commit/437658415a2869ed4236fa31b57128bb9807a2f3))
* Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want these secondary lines. they don't provide any useful information to our customers. can you remove in all the items in here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'd noticed that the bots were including signed commits, which is a small annoyance.

NEWS.md Outdated

#### Miscellaneous Chores

* **deps:** Updated security agent to v0.1.3 ([#1696](https://github.com/newrelic/node-newrelic/pull/1696)) ([0f957bd](https://github.com/newrelic/node-newrelic/commit/0f957bd0e39a32614337b5ade33f07d9729f1897))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this was a security update right? If so, make sure you also edit the changelog.json to move this into the security section

Signed-off-by: mrickard <maurice@mauricerickard.com>
@mrickard mrickard requested a review from bizob2828 June 26, 2023 19:54
"version": "10.3.2",
"changes": {
"security": [
"bump fast-xml-parser and @aws-sdk/client-lambda"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the security fix was the security agent bumping semver, correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the security agent mention on the new line 8 include a mention of semver explicitly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. This is a confusing one esp since the client-lambda was only updated in our repo, but due to semver ranges it'd be fine. so really that one doesn't need to be included.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also looking at the security agent PR they did more than bump semver newrelic/csec-node-agent#59

Signed-off-by: mrickard <maurice@mauricerickard.com>
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #1701 (2ea6956) into main (727c17f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1701   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files         200      200           
  Lines       39181    39181           
  Branches       24       24           
=======================================
  Hits        37956    37956           
  Misses       1225     1225           
Flag Coverage Δ
esm-unit-tests-14.x 47.80% <ø> (ø)
esm-unit-tests-16.x 92.11% <ø> (ø)
esm-unit-tests-18.x 92.11% <ø> (ø)
integration-tests-14.x 78.97% <ø> (-0.02%) ⬇️
integration-tests-16.x 79.08% <ø> (+0.01%) ⬆️
integration-tests-18.x 79.06% <ø> (-0.02%) ⬇️
unit-tests-14.x 91.41% <ø> (ø)
unit-tests-16.x 91.46% <ø> (ø)
unit-tests-18.x 91.44% <ø> (ø)
versioned-tests-14.x 75.70% <ø> (-0.06%) ⬇️
versioned-tests-16.x 77.02% <ø> (-0.06%) ⬇️
versioned-tests-18.x 77.02% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mrickard mrickard merged commit eb1f840 into main Jun 26, 2023
36 checks passed
@mrickard mrickard deleted the release/v10.3.2 branch June 26, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants