Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): Converted server-config.test.js to tap-style #1702

Merged

Conversation

mrickard
Copy link
Member

Description

Converted tests/unit/errors/server-config.test.js from mocha/chai to tap

Related Issues

Closes NR-139321

Signed-off-by: mrickard <maurice@mauricerickard.com>
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1702 (6278be6) into main (86025de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1702   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files         200      200           
  Lines       39181    39181           
  Branches       24       24           
=======================================
  Hits        37956    37956           
  Misses       1225     1225           
Flag Coverage Δ
esm-unit-tests-14.x 47.80% <ø> (ø)
esm-unit-tests-16.x 92.11% <ø> (ø)
esm-unit-tests-18.x 92.11% <ø> (ø)
integration-tests-14.x 78.98% <ø> (+<0.01%) ⬆️
integration-tests-16.x 79.06% <ø> (-0.12%) ⬇️
integration-tests-18.x 79.06% <ø> (ø)
unit-tests-14.x 91.41% <ø> (ø)
unit-tests-16.x 91.46% <ø> (ø)
unit-tests-18.x 91.44% <ø> (ø)
versioned-tests-14.x 75.70% <ø> (-0.07%) ⬇️
versioned-tests-16.x 77.03% <ø> (-0.06%) ⬇️
versioned-tests-18.x 77.03% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bizob2828 bizob2828 self-assigned this Jun 28, 2023
@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label Jun 28, 2023
@bizob2828 bizob2828 merged commit 2c6906d into newrelic:main Jun 28, 2023
22 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Jun 28, 2023
@github-actions github-actions bot mentioned this pull request Jun 30, 2023
@mrickard mrickard deleted the NR-139321/convert-server-config.test-to-tap branch April 29, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants