Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: pin prisma to < 5 when running on node 14 #1717

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

bizob2828
Copy link
Member

Description

Prisma dropped Node 14 in version 5. Until we drop 14, we need to prevent our versioned tests from running >=5 on Node 14. #1715 is also testing if the instrumentation crashes and if we have to do a semver check in instrumentation. This is just to unblock CI.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1717 (b71bf1c) into main (bb42249) will decrease coverage by 5.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1717      +/-   ##
==========================================
- Coverage   96.87%   91.46%   -5.41%     
==========================================
  Files         200      179      -21     
  Lines       39181    37073    -2108     
  Branches       24        0      -24     
==========================================
- Hits        37956    33910    -4046     
- Misses       1225     3163    +1938     
Flag Coverage Δ
esm-unit-tests-14.x ?
esm-unit-tests-16.x ?
esm-unit-tests-18.x ?
integration-tests-14.x ?
integration-tests-16.x ?
integration-tests-18.x ?
unit-tests-14.x ?
unit-tests-16.x 91.46% <ø> (ø)
unit-tests-18.x 91.44% <ø> (ø)
versioned-tests-14.x ?
versioned-tests-16.x ?
versioned-tests-18.x ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 84 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bizob2828 bizob2828 merged commit b000d7b into newrelic:main Jul 12, 2023
19 of 20 checks passed
@github-actions github-actions bot mentioned this pull request Jul 13, 2023
@bizob2828 bizob2828 deleted the pin-prisma branch August 28, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants