Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Updated ioredis tests to assert the host metric getting created on ioredis calls #2230

Merged
merged 1 commit into from
May 29, 2024

Conversation

bizob2828
Copy link
Member

Description

This metric will be used to link APM entities to AWS Elasticache redis services. We had an assertion in redis but not ioredis

How to Test

npm run versioned:internal ioredis

Related Issues

Closes #2228

@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label May 29, 2024
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add a test assertion in ioredis that asserts the instance metrics
3 participants