chore: Updated mysql2 tests to fix CI issue #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrickard
approved these changes
Jun 17, 2024
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in our CI introduced by #2280. The problem is tied to sidorares/node-mysql2#1398. In short,
mysql2@1relies oniconv-lite@0.4.8which does not have an encoding mapping that MySQL server 8+ requires. The fix for themysql2driver is to update to at least version 2.0.0. Given the details outlined in #2269 , I have updated updated our versioned tests to minimally test againstmysql@2.0.0. The consequence is that we do not have coverage for v1 ofmysql2(which was last released 2019-08-28 according to npm).Internally, I can see some usage of the v1 line with v11 of our agent, but the total number at the time of this writing is 16 instances. All other usages of
mysql2@1are on older versions of the agent and still only totals some where in the 10s (i.e. <100).