-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Updated benchmark test results to output result files #2350
Conversation
…om run-bench, promisified the child-exit listener for JSON printing benchmark tests, temporarily bumped complexity threshold Signed-off-by: mrickard <maurice@mauricerickard.com>
…t tests Signed-off-by: mrickard <maurice@mauricerickard.com>
… counter Signed-off-by: mrickard <maurice@mauricerickard.com>
…hat is not wired up any longer
…e method as cb in the test data store
…run-bench to handle non-json returns Signed-off-by: mrickard <maurice@mauricerickard.com>
…ging of error, if a test is missing from one file. Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better, a lot of great improvements here, just a few suggestions
Signed-off-by: mrickard <maurice@mauricerickard.com>
…ark_results directory, removed extra NPM script Signed-off-by: mrickard <maurice@mauricerickard.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👏
Description
Updated
run-bench.js
andbenchmark.js
to complete asynchronous tests before generating statisticsUpdated
run-bench.js
to allow JSON output to a file, and consolidate printing logicReduced cognitive complexity in
run-bench.js
How to Test
npm run bench
to run benchmark tests and output json result files tobenchmark_results
Given two benchJson outputs,
node bin/compare-bench-results.js {file1.json} {file2.json}
will compare two benchmark runs, and write a markdown file tobenchmark_results
.Related Issues
Closes NR-281645