Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Migrated tests in test/unit/instrumentation to use node:test #2531

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

bizob2828
Copy link
Member

Description

Please provide a brief description of the changes introduced in this pull request.
What problem does it solve? What is the context of this change?

How to Test

Please describe how you have tested these changes. Have you run the code against an example application?
What steps did you take to ensure that the changes are working correctly?

Related Issues

Closes #2519

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (9363eb0) to head (cbd1645).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2531      +/-   ##
==========================================
+ Coverage   97.15%   97.19%   +0.03%     
==========================================
  Files         289      289              
  Lines       45415    45416       +1     
==========================================
+ Hits        44123    44140      +17     
+ Misses       1292     1276      -16     
Flag Coverage Δ
integration-tests-cjs-18.x 73.80% <ø> (-0.01%) ⬇️
integration-tests-cjs-20.x 73.82% <ø> (+<0.01%) ⬆️
integration-tests-cjs-22.x 73.85% <ø> (+<0.01%) ⬆️
integration-tests-esm-18.x 49.15% <ø> (+<0.01%) ⬆️
integration-tests-esm-20.x 49.15% <ø> (+<0.01%) ⬆️
integration-tests-esm-22.x 49.18% <ø> (+<0.01%) ⬆️
unit-tests-18.x 88.75% <ø> (+0.08%) ⬆️
unit-tests-20.x 88.75% <ø> (+0.08%) ⬆️
unit-tests-22.x 88.76% <ø> (+0.08%) ⬆️
versioned-tests-18.x 78.84% <ø> (-0.14%) ⬇️
versioned-tests-20.x 78.85% <ø> (-0.14%) ⬇️
versioned-tests-22.x 78.86% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing some inconsistent usage of "scoped globals" vs beforeEach setups. Not a blocker, but I am curious about what circumstances lead to the decision of one style over the other.

test/unit/instrumentation/connect.test.js Outdated Show resolved Hide resolved
test/unit/instrumentation/connect.test.js Outdated Show resolved Hide resolved
test/unit/instrumentation/core/unhandled-rejection.js Outdated Show resolved Hide resolved
test/unit/instrumentation/fastify/spec-builders.test.js Outdated Show resolved Hide resolved
@bizob2828 bizob2828 merged commit 47b8398 into newrelic:main Sep 4, 2024
29 checks passed
@bizob2828 bizob2828 deleted the instrumentation-unit-tests branch September 4, 2024 17:30
@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label Sep 4, 2024
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Convert the instrumentation unit tests to node:test
2 participants