Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Migrated mysql and mysql2 versioned tests to node:test #2711

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

bizob2828
Copy link
Member

Description

These tests were the same aside from the library under test and 1 that only exists in mysql2. I ported to node test and also consolidated for easier maintenance in future.

Related Issues

Closes #2683

@bizob2828 bizob2828 force-pushed the migrate-mysql-tests branch from 9b4b237 to 76a9163 Compare November 7, 2024 22:38
@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label Nov 7, 2024
@bizob2828 bizob2828 force-pushed the migrate-mysql-tests branch from 76a9163 to b770ec1 Compare November 8, 2024 16:48
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (0c897ab) to head (b770ec1).
Report is 7 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (0c897ab) and HEAD (b770ec1). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (0c897ab) HEAD (b770ec1)
unit-tests-18.x 1 0
unit-tests-20.x 1 0
unit-tests-22.x 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2711      +/-   ##
==========================================
- Coverage   97.24%   88.78%   -8.47%     
==========================================
  Files         294      293       -1     
  Lines       46125    46110      -15     
==========================================
- Hits        44855    40937    -3918     
- Misses       1270     5173    +3903     
Flag Coverage Δ
integration-tests-cjs-18.x 74.29% <ø> (ø)
integration-tests-cjs-20.x 74.30% <ø> (ø)
integration-tests-cjs-22.x 74.33% <ø> (ø)
integration-tests-esm-18.x 49.89% <ø> (ø)
integration-tests-esm-20.x 49.90% <ø> (ø)
integration-tests-esm-22.x 49.93% <ø> (ø)
unit-tests-18.x ?
unit-tests-20.x ?
unit-tests-22.x ?
versioned-tests-18.x 78.95% <ø> (-0.19%) ⬇️
versioned-tests-20.x 78.95% <ø> (-0.19%) ⬇️
versioned-tests-22.x 78.96% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 merged commit fc767e0 into newrelic:main Nov 8, 2024
26 of 27 checks passed
@bizob2828 bizob2828 deleted the migrate-mysql-tests branch November 8, 2024 20:28
@github-actions github-actions bot mentioned this pull request Nov 11, 2024
jsumners-nr pushed a commit to jsumners-nr/node-newrelic that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Migrate mysql and mysql2 versioned tests to node:test
2 participants