Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated kafkajs, langchain, & openai tests to node:test #2723

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

jsumners-nr
Copy link
Contributor

This PR resolves #2684 and supersedes #2722.

@jsumners-nr jsumners-nr added the dev:tests Indicates only changes to tests label Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.20%. Comparing base (a901a24) to head (798e81c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2723      +/-   ##
==========================================
- Coverage   97.25%   97.20%   -0.05%     
==========================================
  Files         294      294              
  Lines       46198    46198              
==========================================
- Hits        44930    44908      -22     
- Misses       1268     1290      +22     
Flag Coverage Δ
integration-tests-cjs-18.x 74.27% <ø> (ø)
integration-tests-cjs-20.x 74.28% <ø> (ø)
integration-tests-cjs-22.x 74.31% <ø> (-0.01%) ⬇️
integration-tests-esm-18.x 49.88% <ø> (ø)
integration-tests-esm-20.x 49.89% <ø> (ø)
integration-tests-esm-22.x 49.91% <ø> (ø)
unit-tests-18.x 88.93% <ø> (ø)
unit-tests-20.x 88.93% <ø> (ø)
unit-tests-22.x 88.93% <ø> (ø)
versioned-tests-18.x 78.95% <ø> (-0.21%) ⬇️
versioned-tests-20.x 78.98% <ø> (-0.18%) ⬇️
versioned-tests-22.x 78.99% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsumners-nr jsumners-nr marked this pull request as ready for review November 12, 2024 19:05
@bizob2828 bizob2828 merged commit b6e4c5d into newrelic:main Nov 12, 2024
28 of 29 checks passed
@jsumners-nr jsumners-nr deleted the issue-2684-redo branch November 12, 2024 19:36
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Migrate kafkajs langchain openai versioned tests to node:test
2 participants