Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated agent integration tests to node:test #2782

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

jsumners-nr
Copy link
Contributor

This PR resolves #2766.

@jsumners-nr jsumners-nr added the dev:tests Indicates only changes to tests label Nov 22, 2024
test/integration/agent/serverless-harvest.test.js Outdated Show resolved Hide resolved
test/lib/test-reporter.mjs Outdated Show resolved Hide resolved
@jsumners-nr jsumners-nr marked this pull request as ready for review November 22, 2024 14:35
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (36bc0e7) to head (fea05d2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2782      +/-   ##
==========================================
- Coverage   97.24%   97.21%   -0.03%     
==========================================
  Files         294      294              
  Lines       46315    46315              
==========================================
- Hits        45038    45025      -13     
- Misses       1277     1290      +13     
Flag Coverage Δ
integration-tests-cjs-18.x 74.27% <ø> (?)
integration-tests-cjs-20.x 74.28% <ø> (-0.01%) ⬇️
integration-tests-cjs-22.x 74.33% <ø> (+<0.01%) ⬆️
integration-tests-esm-18.x 49.97% <ø> (ø)
integration-tests-esm-20.x 49.98% <ø> (ø)
integration-tests-esm-22.x 50.00% <ø> (ø)
unit-tests-18.x 88.98% <ø> (?)
unit-tests-20.x 88.98% <ø> (ø)
unit-tests-22.x 88.99% <ø> (ø)
versioned-tests-18.x 78.99% <ø> (-0.20%) ⬇️
versioned-tests-20.x 78.99% <ø> (-0.20%) ⬇️
versioned-tests-22.x 79.00% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

test/lib/test-reporter.mjs Outdated Show resolved Hide resolved
test/lib/test-reporter.mjs Outdated Show resolved Hide resolved
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. WRT the reporter, I think we can focus on that in a separate ticket because i also notice the pass/failed/total isn't correct

@jsumners-nr jsumners-nr merged commit d556512 into newrelic:main Nov 22, 2024
26 of 27 checks passed
@jsumners-nr jsumners-nr deleted the issue-2766 branch November 22, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Migrate agent integration tests to node:test
2 participants