test: Added test/custom-assertions.js to the apollo-server external versioned tests config
#2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… versioned tests config
bizob2828
commented
Dec 5, 2024
| @@ -19,6 +19,7 @@ const repos = [ | |||
| additionalFiles: [ | |||
| 'tests/agent-testing.js', | |||
| 'tests/create-apollo-server-setup.js', | |||
| 'tests/custom-assertions.js', | |||
There was a problem hiding this comment.
i think long term we should prob move all these files into a tests/lib and then update this stanza to just include that folder
jsumners-nr
approved these changes
Dec 5, 2024
Then we def should move these files into a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2817 +/- ##
==========================================
- Coverage 97.17% 97.13% -0.04%
==========================================
Files 294 294
Lines 46403 46403
==========================================
- Hits 45091 45074 -17
- Misses 1312 1329 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The external versioned tests were failing since merging: newrelic/newrelic-node-apollo-server-plugin#333. I added a file that was not included in the config for the apollo server tests.
How to Test