feat: Added segment synthesis for db client otel spans to db trace #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2820 +/- ##
=======================================
Coverage 97.26% 97.27%
=======================================
Files 297 299 +2
Lines 46907 46983 +76
=======================================
+ Hits 45626 45702 +76
Misses 1281 1281
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsumners-nr
approved these changes
Dec 6, 2024
| return this.createExternalSegment(otelSpan) | ||
| } else if (rule.type === 'db') { | ||
| return this.createDatabaseSegment(otelSpan) |
There was a problem hiding this comment.
I think this file is going to become difficult to understand if we keep adding methods to it. We'll probably want to split things out after we PoC everything to stuff like return new DatabaseSegment(otelSpan).
There was a problem hiding this comment.
Yea. Ive already noted that for the next story I do
bizob2828
added a commit
that referenced
this pull request
Dec 9, 2024
bizob2828
added a commit
that referenced
this pull request
Dec 12, 2024
bizob2828
added a commit
that referenced
this pull request
Dec 13, 2024
bizob2828
added a commit
that referenced
this pull request
Dec 16, 2024
bizob2828
added a commit
that referenced
this pull request
Dec 19, 2024
bizob2828
added a commit
that referenced
this pull request
Jan 13, 2025
bizob2828
added a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The transformation rules key off of client as span kind and db.system to do its matching. However some of the required attributes for naming do not exist in Node.js opentelemetry instrumetation. Most
db.sql.table. For traditional sql database libs we must parse the SQL to extract the operation and table. I also cross referenced our instrumentation to determine how we name segments for databases:Segment naming for all dbs:
Datastore/statement/MySQL/<table>/<operation>Datastore/statement/Postgres/<table>/<operation>Datastore/operation/Redis/<operation>Datastore/statement/MongoDB/<collectionorDatastore/operation/MongoDB/<operation>Datastore/statement/ElasticSearch/<index>/<operation>orDatastore/operation/ElasticSearch/<operation>Datastore/statement/Cassandra/<keyspace>.<table>/<operation>orDatastore/operation/Cassandra/<operation>Datastore/operation/Memcache/<operation>The only difference here will be mongodb/elasticsearch as all will be prefixed with
Datastore/statementHow to Test
Related Issues
Closes #2647