fix: Fixed issue with bluebird and when instrumentation where checking active context crashed when transaction prematurely ends
#2909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cking active context crashed when transaction prematurely ends
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2909 +/- ##
==========================================
- Coverage 90.26% 88.82% -1.44%
==========================================
Files 289 299 +10
Lines 45807 46791 +984
==========================================
+ Hits 41347 41563 +216
- Misses 4460 5228 +768
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsumners-nr
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A customer reported a regression(#2908) when upgrading to 12.11.0+. This surfaced when we removed the transaction from segment and there was some naive checking in both promise-shim and when instrumentation.
This PR adds some defensive code to handle when a transaction prematurely ends and instrumentation for
whenandbluebirdattempt to check if it has to propagate the segment/transaction through the promise methods.I also added some tests to assert that this behavior has been fixed. If you run the tests without the code, change it crashes with same reported error.
Related Issues
Closes #2908