Updated the MSSQL driver to use Azure tokens #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng Azure Tokens instead of user pass
|
Is this backwards compatible with the existing implementation? I can't see anything in the main readme confirming this. |
Dkairu
changed the title
|
@Kav91 Yes as a matter of fact it uses the modules from the original driver https://github.com/denisenkom/go-mssqldb/blob/master/azuread/driver.go. I did test with a user name and password and it works. This is also called out in the main README see https://github.com/denisenkom/go-mssqldb/tree/master?tab=readme-ov-file#azure-active-directory-authentication // Import the Azure AD driver module (also imports the regular driver package) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current MSSQL driver uses username and password to authenticate but not enough options are offered to authenticate against MS Entra ID formerly Active directory…This PR gives additional options like using tokens that are dynamically generated from Entra ID/ Active Directory instead of user password to provide flexibility of using the integration.