Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use go 1.19 to asure compatibilty with older OS #135

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

sigilioso
Copy link
Contributor

1.20 compiled binary doesn't work on OS with glic versions different from 2.32. Example in ubuntu focal (20.04):

/var/db/newrelic-infra/newrelic-integrations/bin/nri-oracledb -show_version
/var/db/newrelic-infra/newrelic-integrations/bin/nri-oracledb: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /var/db/newrelic-infra/newrelic-integrations/bin/nri-oracledb)

Additional context:

@sigilioso sigilioso requested a review from a team August 8, 2023 15:22
Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sigilioso sigilioso merged commit 405feb1 into master Aug 9, 2023
8 checks passed
@sigilioso sigilioso deleted the fix/golang-1.19 branch August 9, 2023 12:44
@AXDOOMER
Copy link

AXDOOMER commented Sep 7, 2023

You could just have used bullseye instead of bookworm and kept using Go 1.21

@sigilioso
Copy link
Contributor Author

Thanks for bringing it up. It was to buster in #142 and we'll keep it in mind when updating to Go 1.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants