Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: report coverage to codeclimate #113

Merged
merged 4 commits into from
Dec 14, 2020
Merged

ci: report coverage to codeclimate #113

merged 4 commits into from
Dec 14, 2020

Conversation

nadiamoe
Copy link
Contributor

@nadiamoe nadiamoe commented Dec 4, 2020

This PR enables reporting coverage data to CodeClimate through GHA.

Additionally, I have remove the coverage.xml file which I don't think that should have been commited in the first place.

Gotchas

  • coverageLocations should not be needed, but a bug in the codeclimate action breaks reporting if ommited. A fix for that bug is already submitted upstream and hopefully will land soon.
    • Issue closed upstream, workaround removed
  • CC_TEST_REPORTER_ID does not need to kept secret. Making it public has some pros and cons:
    • ➖ Ill-intended agents could upload fake coverage reports to codeclimate, which could potentially deface PR stats. However, codeclimate prevents multiple reports for a single commit, so a potential malicious agent would need to be faster uploading the fake report for a PR than the CI is. I deem that unlikely, or at least too costly for a prankster.
    • ➕ We save from adding more secrets to the repo
    • ➕➕ We are able to see coverage diff for external PRs

@nadiamoe nadiamoe force-pushed the santalla/codeclimate branch 11 times, most recently from eb6a092 to b0e1cbe Compare December 4, 2020 15:26
@nadiamoe nadiamoe force-pushed the santalla/codeclimate branch from b0e1cbe to 5c73dd6 Compare December 4, 2020 15:45
@nadiamoe nadiamoe requested a review from a team December 7, 2020 13:59
@nadiamoe nadiamoe force-pushed the santalla/codeclimate branch from 5f546dc to b75722d Compare December 10, 2020 09:24
@nadiamoe nadiamoe merged commit 40979ce into main Dec 14, 2020
@nadiamoe nadiamoe deleted the santalla/codeclimate branch December 14, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant