Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(infra_emitter): add common attributes #208

Merged
merged 4 commits into from
Jul 1, 2021
Merged

feat(infra_emitter): add common attributes #208

merged 4 commits into from
Jul 1, 2021

Conversation

gsanchezgavier
Copy link
Contributor

This PR fixes https://github.com/newrelic/newrelic-coreint/issues/109

It also removes the following attributes from the metrics since they are not needed on the sdkV4 protocol:

  • nrMetricType
  • promMetricType
  • integrationVersion this was replaced by instrumentation.version populated in the Agent from the Integration Metadata
  • integrationName this was replaced by instrumentation.name populated in the Agent from the Integration Metadata

@gsanchezgavier gsanchezgavier changed the base branch from main to feature/entity_synthesis June 29, 2021 16:13
ivancorrales
ivancorrales reviewed Jun 30, 2021
View reviewed changes
Copy link

@ivancorrales ivancorrales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_

roobre
roobre approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@roobre roobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The only thing I'd add is an integration test to ensure that the produced metrics no longer have targetName and friends as non-common attributes.

Base automatically changed from feature/entity_synthesis to main July 1, 2021 12:53
@gsanchezgavier gsanchezgavier force-pushed the feature/sdk_common_attributes branch 2 times, most recently from 96d8d3e to e3aa4c1 Compare July 1, 2021 14:22
@gsanchezgavier gsanchezgavier merged commit ee5bbe0 into main Jul 1, 2021
@gsanchezgavier gsanchezgavier deleted the feature/sdk_common_attributes branch July 1, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivancorrales ivancorrales ivancorrales left review comments

@roobre roobre roobre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsanchezgavier @roobre @ivancorrales