Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove static manifests from this repo #237

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Conversation

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2021

CLA assistant check
All committers have signed the CLA.

@kang-makes kang-makes requested a review from a team October 28, 2021 19:04
@kang-makes kang-makes marked this pull request as draft October 28, 2021 19:04
@kang-makes kang-makes removed the request for review from a team October 28, 2021 19:04
@kang-makes kang-makes marked this pull request as ready for review October 28, 2021 19:12
@kang-makes kang-makes requested a review from a team October 28, 2021 19:13
Copy link
Member

@paologallinaharbur paologallinaharbur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Guillermo mentioned in the other PR it would make sense to garbage collect secrets.
Also updatin the changelog.md (but we can do it also at release time)

@kang-makes kang-makes merged commit 24a4cbe into main Nov 2, 2021
@kang-makes kang-makes deleted the cleaning/static-manifests branch November 2, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants