Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/listening address #371

Merged
merged 6 commits into from
Dec 7, 2022
Merged

Feat/listening address #371

merged 6 commits into from
Dec 7, 2022

Conversation

paologallinaharbur
Copy link
Member

Testing it locally with:

cluster_name: test
license_key: test2
go run ./cmd/nri-prometheus/... -config_path ./config
curl localhost:8080/metrics
# HELP go_gc_duration_seconds A summary of the pause duration of garbage collection cycles.
# TYPE go_gc_duration_seconds summary
go_gc_duration_seconds{quantile="0"} 0.000131

Adding

cluster_name: test
license_key: test2
self_metrics_listening_address: ":8181"

We can run:

curl localhost:8181/metrics
# HELP go_gc_duration_seconds A summary of the pause duration of garbage collection cycles.
# TYPE go_gc_duration_seconds summary
go_gc_duration_seconds{quantile="0"} 0.000131

@paologallinaharbur paologallinaharbur requested a review from a team December 5, 2022 11:57
Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@paologallinaharbur paologallinaharbur merged commit f1aecab into main Dec 7, 2022
@paologallinaharbur paologallinaharbur deleted the feat/listeningAddress branch December 7, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants