Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra agent: enforce utf8 encoding on Windows config #1109

Merged
merged 1 commit into from
Aug 20, 2024
Merged

infra agent: enforce utf8 encoding on Windows config #1109

merged 1 commit into from
Aug 20, 2024

Conversation

rubenruizdegauna
Copy link
Contributor

@rubenruizdegauna rubenruizdegauna commented Aug 20, 2024 •
edited
Loading

Infra Agent config file on Windows has ANSI Encoding by default. This PR makes it UTF8.

@rubenruizdegauna rubenruizdegauna marked this pull request as ready for review August 20, 2024 10:26
alvarocabanas
alvarocabanas approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@alvarocabanas alvarocabanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahmmcgivern noahmmcgivern merged commit a8289a1 into main Aug 20, 2024
20 checks passed
@noahmmcgivern noahmmcgivern deleted the windows_infra_agent_config_utf8 branch August 20, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahmmcgivern noahmmcgivern noahmmcgivern approved these changes

@alvarocabanas alvarocabanas alvarocabanas approved these changes

@DavSanchez DavSanchez Awaiting requested review from DavSanchez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rubenruizdegauna @alvarocabanas @noahmmcgivern